disable cross-validation of defaults#434
Merged
minrk merged 1 commit intoipython:masterfrom Aug 9, 2017
Merged
Conversation
Contributor
|
As mentioned in other threads, I agree that the cross-validation of defaults creates too many issues downstream for it to be a worthwhile feature (though it could be done in a backwards compatible way with |
Member
Author
|
@rmorshea thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it causes loads of problems with nontrivial validation/observer combinations, including prematurely validating unused values and infinite recursion.
Given that validation of default values should only have an effect when those default values are initially invalid, there seems to be little benefit to introducing the complexity of validating defaults that may not be used.
With this change, ipywidgets tests pass again.
Closes #363
closes #435
#435 is an attempt to fix the problems without removing cross-validation of defaults. I think it's probably better to not cross-validate defaults, but it does get reported as a bug (#428), so we might give it a try.