Conversation
traitlets/config/application.py
Outdated
| log.debug("Looking for %s in %s", basefilename, path) | ||
| jsonloader = cls.json_config_loader_class(basefilename+'.json', path=path, log=log) | ||
| # path list is in descending priority order, so load files backwards: | ||
| def new_loader(name, path): |
There was a problem hiding this comment.
No reason to define new_loader inside the for-loop over path[::-1] on line 537
Wherever a config_file.{py|json} would be loaded, also load any/all config in config_file.d/*.{py|json}.
|
@minrk This change hasn't been merged yet ? Is it because we don't need it in light of jupyter/notebook#2108 ? |
|
I think we still do want this in general, but it is no longer an urgent need thanks to that PR. |
|
Raised some questions about py/json vs env/home precendence. Would love to see this finally put to rest! |
| jsonloader = cls.json_config_loader_class(basefilename+'.json', path=path, log=log) | ||
| pyloader = new_loader(basefilename + '.py', path=path) | ||
| jsonloader = new_loader(basefilename + '.json', path=path) | ||
| loaders = [pyloader, jsonloader] |
There was a problem hiding this comment.
I have a question not strictly related to the core functionality of this PR
Why did you changed the separate cls.XXX_config_loader_class() calls with new_loader()?
I also need to change the abov 3 lines,
but for adding a new loader (i.e. YAML) without overriding and reimplementing _load_config_files(),
like that:
- pyloader = cls.python_config_loader_class(basefilename+'.py', path=path, log=log)
if log:
log.debug("Looking for %s in %s", basefilename, path or os.getcwd())
- jsonloader = cls.json_config_loader_class(basefilename+'.json', path=path, log=log)
+ loaders = cls._make_loaders(basefilename, path=path, log=log)
+ log.debug("Looking for %s in %s", basefilename, path or os.getcwd())You may implement _make_loaders() either with new_loader() or cls.XXX_config_loader_class() calls.
Then adding a new loader requires only to overrd this trivial method.
…xtensible
- Deprecate Application class-attribute:
- python_config_loader_class
- json_config_loader_class
replaced by `supported_cfg_loaders` ordered mapping:
{.ext: loader-class}
- To extend with a new config-file, simply add its loader class in the
`supported_cfg_loaders` mapping.
- Merge-conflicts resolved in Application.
…xtensible
- Deprecate Application class-attribute:
- python_config_loader_class
- json_config_loader_class
replaced by `supported_cfg_loaders` ordered mapping:
{.ext: loader-class}
- To extend with a new config-file, simply add its loader class in the
`supported_cfg_loaders` mapping.
- Merge-conflicts resolved in Application.
But NOT USED actually.
But NOT USED actually.
|
Closing as state for 2 years Labelling accordingly to easily reopen if necessary. Will try to do some cleanup to not have multiple pages of stale PR. |
6 participants
Wherever a
config_file.{py|json}would be loaded, also load any/all config inconfig_file.d/*.{py|json}.This is a prototype for discussion in jupyter/notebook#1508
closes #192