Text highlight fragment share as Experiment - URL Mode History#1512
Draft
schu96 wants to merge 11 commits intointernetarchive:masterfrom
Draft
Text highlight fragment share as Experiment - URL Mode History#1512schu96 wants to merge 11 commits intointernetarchive:masterfrom
schu96 wants to merge 11 commits intointernetarchive:masterfrom
Conversation
schu96
force-pushed
the
custom-live-server
branch
from
548778a to
4cdb476
Compare
schu96
force-pushed
the
custom-live-server
branch
2 times, most recently
from
75cbf87 to
d13eff6
Compare
Include fix for breaking tests again
schu96
force-pushed
the
custom-live-server
branch
from
d13eff6 to
a523b45
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1512 +/- ##
==========================================
- Coverage 69.70% 68.86% -0.84%
==========================================
Files 65 65
Lines 5373 5553 +180
Branches 1182 1229 +47
==========================================
+ Hits 3745 3824 +79
- Misses 1594 1695 +101
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schu96
changed the title
cdrini
reviewed
Mar 4, 2026
Contributor
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Looking great! A number of code quality fixes / naming / etc. Note I got up to src/util/TextSelectionManager.js, but still have the rest of the diff to get through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.