Fix: Detect browser language and use for Translate plugin 'To' language#1461
Open
antcybersec wants to merge 2 commits intointernetarchive:masterfrom
Open
Fix: Detect browser language and use for Translate plugin 'To' language#1461antcybersec wants to merge 2 commits intointernetarchive:masterfrom
antcybersec wants to merge 2 commits intointernetarchive:masterfrom
Conversation
- Detect browser language using navigator.language - Convert to ISO6391 format using toISO6391 utility - Check if browser language is available in translation models - Set browser language as default 'To' language if available, otherwise fallback to English - Fixes issue internetarchive#1459
- Removed unnecessary whitespace in the language detection logic - Improved code readability without altering functionality
antcybersec
commented
Dec 20, 2025
Author
antcybersec
left a comment
antcybersec
left a comment
There was a problem hiding this comment.
hey @cdrini can you check the PR once again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here is the screenshot of the fix: