Conversation
|
|
||
| ## Building and configuring zlib-accel | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Provide link to zlib-accel repo here (than in references) and
probably add explicit clone to /opt/zlib-accel, since you have that path in the next LD_PRELOAD command.
|
Claude Code review: SummaryThis PR adds a new guide (software/cassandra/QAT/README.md) for using Cassandra with Intel QAT hardware-accelerated compression via the zlib-accel Existing Review Comments (by rsiyer-intel)There are 4 unresolved comments that should be addressed:
Additional Issues I FoundTypos / grammar:
Content issues:
Missing context:
Overall the guide covers the right topics but needs a pass for typos, broken links, and the duplicate/missing firmware download commands before merging. |
software/cassandra/QAT/README.md
Outdated
|
|
||
| ## Benchmarking Cassandra with QAT | ||
|
|
||
| NoSQLBench is used for benchmarking Cassandra. The results mentioned in the Overview section were generated by using 6 independent Cassandra servers and servers. The benchmark used a mix of 80% reads and 20% writes using the default CQL timeseries schema. |
There was a problem hiding this comment.
Do you have any performance charts that can be shared besides the summary in the Overview section?
And any commandlines used for NoSQLBench if anyone wants to reproduce the results.
rsiyer-intel
left a comment
There was a problem hiding this comment.
Thanks Sri. Left few comments and suggestions.
Typo Co-authored-by: rsiyer-intel <rukmini.subramanian.iyer@intel.com>
Typo Co-authored-by: rsiyer-intel <rukmini.subramanian.iyer@intel.com>
Typo Co-authored-by: rsiyer-intel <rukmini.subramanian.iyer@intel.com>
Co-authored-by: rsiyer-intel <rukmini.subramanian.iyer@intel.com>
| ## Using Cassandra with zlib-accel | ||
|
|
||
| Once the zlib-accel library has been built, It is simple to use Cassandra to enable hardware compression. | ||
| [zlib-accel] (https://github.com/intel/zlib-accel) can be built with: |
There was a problem hiding this comment.
zlib-accel can be built with.
Remove space after [zlib-accel]
| cd build | ||
| cmake -DUSE_QAT=ON -DUSE_IAA=OFF -DDEBUG_LOG=OFF -DCOVERAGE=OFF -DCMAKE_BUILD_TYPE=Release | ||
| make | ||
| ``` |
There was a problem hiding this comment.
Why do we need zlib-accel build steps twice?
Is it once for generic build and once for Cassandra?
It's not clear, does the /etc/zlib-accel.conf change when building for Cassandra?
If everything is same, then probably we don't need build steps twice. Leave it up to you.
The purpose of this PR is show benefits of using Cassandra with QAT. It has been reviewed by both the Java team and the QAT team. The PCR for the performance claim was approved in PCR-1423