Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

[MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code (cherry-pick from upstream)#181

Merged
hrotuna merged 1 commit intointel:npu/release/20.xfrom
BogdanDragosV:dragosva/attr_namespace_patch
Nov 21, 2025
Merged

[MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code (cherry-pick from upstream)#181
hrotuna merged 1 commit intointel:npu/release/20.xfrom
BogdanDragosV:dragosva/attr_namespace_patch

Conversation

@BogdanDragosV
Copy link
Copy Markdown

@BogdanDragosV BogdanDragosV commented Nov 21, 2025

Summary

ODS generate code can be included and used outside of the mlir
namespace and so references to symbols in the mlir namespace
must be fully qualified.

JIRA ticket

EISW-190450
[Core] Remove SmallVectorU8Prop and temporary optional property from core dialect

Related PR in NPU Compiler and/or OpenVINO repository with sub-module update

(llvm/llvm-project#168536)

Other related tickets

List tickets for additional work, eg, something was found during review but you agreed to address it in another Jira

  • E-xxxxx

@BogdanDragosV BogdanDragosV requested a review from a team as a code owner November 21, 2025 09:48
…ted code (#168536)

ODS generate code can be included and used outside of the `mlir`
namespace and so references to symbols in the mlir namespace
must be fully qualified.
@BogdanDragosV BogdanDragosV changed the title Patch Attribute namespace [MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code Nov 21, 2025
@BogdanDragosV BogdanDragosV changed the title [MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code [MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code (cherry-pick from upstream) Nov 21, 2025
Copy link
Copy Markdown
Contributor

@andrey-golubev andrey-golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@hrotuna hrotuna merged commit c7f2ed1 into intel:npu/release/20.x Nov 21, 2025
7 of 8 checks passed
ermilindwalekar pushed a commit to ermilindwalekar/npu-plugin-llvm that referenced this pull request Nov 27, 2025
…ted code (#168536) (intel#181)

ODS generate code can be included and used outside of the `mlir`
namespace and so references to symbols in the mlir namespace
must be fully qualified.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants