This repository was archived by the owner on Nov 27, 2025. It is now read-only.
[EISW-164790] Minor fix to quant dialect's TypeParser#112
Open
sartil wants to merge 1 commit intointel:npu/release/18.xfrom
Open
[EISW-164790] Minor fix to quant dialect's TypeParser#112sartil wants to merge 1 commit intointel:npu/release/18.xfrom
sartil wants to merge 1 commit intointel:npu/release/18.xfrom
Conversation
sartil
changed the title
Contributor
Author
|
|
Contributor
fyi, there is a precommit job: pr_checks/pr_check_llvm_test — Tests Passed |
Contributor
andrey-golubev
left a comment
andrey-golubev
left a comment
There was a problem hiding this comment.
Can you add a test here? Also, would it be possible to submit this patch directly to upstream MLIR (and then cherry-pick to us)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passing signedness when creating unsigned integer for the storageType in type parser, to create an actual unsigned integer.
JIRA ticket
Related PR in NPU Compiler and/or OpenVINO repository with sub-module update
Other related tickets