Add clang-tidy checker to use free functions for casting#103
Add clang-tidy checker to use free functions for casting#103ArtemySkrebkov wants to merge 3 commits intointel:npu/release/18.xfrom
Conversation
|
To be honest, I am not sure we need to merge this as this checker becomes useless once we move to LLVM19. So the checker can live in a branch. However, there is no harm in merging as well. For the sake of history, for example 😺 So it is up to the maintainers of the repo to decide what to do with the PR. |
I wouldn't merge (at least as-is) since there's no tests and a few "FIXME" left |
clang-tools-extra/clang-tidy/misc/UseFreeFunctionVariantsCheck.cpp
Outdated
Show resolved
Hide resolved
clang-tools-extra/clang-tidy/misc/UseFreeFunctionVariantsCheck.cpp
Outdated
Show resolved
Hide resolved
Given that we are about to migrate to LLVM19, do we still need this? |
|
I do no think so. Once we have every occurrence of cast methods removed, the PR can be closed. I keep it here just to have a way to fix something quickly. |
Summary
More examples in https://github.com/intel-innersource/applications.ai.vpu-accelerators.vpux-plugin/pull/16360
JIRA ticket
Related PR in NPU Compiler and/or OpenVINO repository with sub-module update
Other related tickets