Conversation
|
We don't publish DEVs .whl. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
We don't publish DEVs .whl. |
pyproject.toml
Outdated
|
|
||
| [project] | ||
| name = "mfd-powermanagement" | ||
| description = "Module for managing power (Raritan, APC, Digital Loggers, ipmi, etc." |
|
We don't publish DEVs .whl. |
1 similar comment
|
We don't publish DEVs .whl. |
|
We don't publish DEVs .whl. |
1 similar comment
|
We don't publish DEVs .whl. |
Signed-off-by: Hubert Cymerys <hubert.cymerys@intel.com>
|
We don't publish DEVs .whl. |
1 similar comment
|
We don't publish DEVs .whl. |
There was a problem hiding this comment.
Pull Request Overview
This initial commit adds the core power-management modules, extensive documentation, reusable GitHub Actions workflows, and a full suite of unit tests.
- Introduced system, PDU, IPMI, DLI, and CCSG power-management implementations with matching tests
- Added reusable workflows for build, test, release, and security scanning
- Populated Sphinx documentation and examples for each module
Reviewed Changes
Copilot reviewed 55 out of 57 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/build_upload_whl.yml | Reusable build/test/release workflow for Python packages |
| mfd_powermanagement/system/windows.py | Stub Windows implementation; get_available_power_states unimplemented |
| mfd_powermanagement/ccsg.py | CCSG implementation; constructs SOAP payload and parses responses |
| examples/system_power_management_example.py | Example showing detection of OS and state changes via SystemPowerManagement |
Comments suppressed due to low confidence (2)
mfd_powermanagement/base.py:60
- [nitpick] The abstract
set_statesignature returnsbool, but implementations in system modules returnNone(from Linux/Windows) orbool(from DLI). Standardize the return type across all implementations.
def set_state(self, **kwargs) -> bool:
examples/system_power_management_example.py:14
- [nitpick] This example calls
get_available_power_stateson Windows, where it's unimplemented and will raise NotImplementedError. Update the example or note OS support/limitations in the docs.
logger.log(level=logging.DEBUG, msg=f"Available power states: {system_pm.get_available_power_states()}")
This pull request introduces several new workflows, documentation updates, and enhancements to the
mfd-powermanagementproject. The most significant changes include the addition of reusable GitHub Actions workflows, comprehensive documentation for power management modules, and updates to licensing and contributor information.GitHub Actions Workflows:
.github/workflows/build_upload_whl.yml: Added a reusable workflow for building and optionally uploading Python packages to PyPI. It includes support for version bumping, virtual environment setup, and running unit/functional tests..github/workflows/manual_release.yml: Introduced a workflow for manual release builds with matrix configurations for Python versions and package upload options..github/workflows/pull_requests.yml: Added a workflow triggered on pull requests to build Python packages for development purposes..github/workflows/codeql.yml: Implemented a CodeQL analysis workflow for code scanning and security checks.Documentation Updates:
README.md: Added detailed project overview, usage instructions, supported tools, and OS compatibility information.AUTHORS.md: Listed project contributors with their contact information.LICENSE.md: Included the MIT license for the project.CCSG.md: Explained CCSG power management methods and usage.DLI.md: Provided details on controlling Digital Loggers power devices.IPMI.md: Documented IPMI-based power management with examples.PDU.md: Described SNMP-based power management for supported devices.Miscellaneous:
CONTRIBUTING.md: Updated project name and license reference.