Skip to content

[SYCL] Don't use std::optional<device> in level_zero.hpp header #21682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
againull wants to merge 1 commit into
base: sycl
Choose a base branch
from
Draft

[SYCL] Don't use std::optional<device> in level_zero.hpp header #21682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions sycl/include/sycl/ext/oneapi/backend/level_zero.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,16 @@ inline context make_context<backend::ext_oneapi_level_zero>(
}

namespace detail {
inline std::optional<sycl::device> find_matching_descendent_device(
sycl::device d,
inline bool find_matching_descendent_device(
const sycl::device &d,
const backend_input_t<backend::ext_oneapi_level_zero, device>
&BackendObject) {
if (get_native<backend::ext_oneapi_level_zero>(d) == BackendObject)
return d;
&BackendObject,
sycl::device &Out) {
if (get_native<backend::ext_oneapi_level_zero>(d) == BackendObject) {
Out = d;
return true;
}

std::vector<info::partition_property> partition_props =
d.get_info<info::device::partition_properties>();

Expand All @@ -79,14 +83,13 @@ inline std::optional<sycl::device> find_matching_descendent_device(
info::partition_property::partition_by_affinity_domain>(
info::partition_affinity_domain::next_partitionable);
for (auto &sub_dev : sub_devices) {
if (auto maybe_device =
find_matching_descendent_device(sub_dev, BackendObject))
return maybe_device;
if (find_matching_descendent_device(sub_dev, BackendObject, Out))
return true;
}
}
}

return {};
return false;
}
} // namespace detail

Expand All @@ -113,9 +116,10 @@ inline device make_device<backend::ext_oneapi_level_zero>(
continue;

for (auto &d : p.get_devices()) {
if (auto maybe_device =
detail::find_matching_descendent_device(d, BackendObject))
return *maybe_device;
sycl::device FoundDevice;
if (detail::find_matching_descendent_device(d, BackendObject,
FoundDevice))
return FoundDevice;
}
}

Expand Down
Loading