[UR][L0v2] Always set NON_IMMEDIATE flag on counter-based events#21662
Draft
adamfidel wants to merge 1 commit intointel:syclfrom
Draft
[UR][L0v2] Always set NON_IMMEDIATE flag on counter-based events#21662adamfidel wants to merge 1 commit intointel:syclfrom
adamfidel wants to merge 1 commit intointel:syclfrom
Conversation
adamfidel
added
the
run-perf-tests
Member
Author
|
Performance run: https://github.com/intel/llvm/actions/runs/23869749040. |
Contributor
It failed, see logs. I think you might need to rebase the PR. |
Contributor
Benchmarks failed because UR has changed. I've already fixed that in Compute Benchmarks and soon I'll fix that in our framework as well. I'll let you know when it's ready to rebase. |
Contributor
|
FYI, benchmarks should be fixed now (ref. #21662). |
Set ZEX_COUNTER_BASED_EVENT_FLAG_NON_IMMEDIATE unconditionally so that counter-based events are compatible with Level Zero graph record & replay, which requires both IMMEDIATE and NON_IMMEDIATE flags to be set.
adamfidel
force-pushed
the
adam/l0v2-counter-event-non-immediate-flag
branch
from
9d851d2 to
f1a9f02
Compare
Member
Author
|
Rebased and kicked off a new run: https://github.com/intel/llvm/actions/runs/24034919838 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
ZEX_COUNTER_BASED_EVENT_FLAG_NON_IMMEDIATEunconditionally so that counter-based events are compatible with Level Zero graph record & replay, which requires both immediate and non-immediate flags to be set.Part of #21626.