Merged
Conversation
Problem: - `id_irq` is a hack. Where we're going, we don't need it. Solution: - Remove it.
Problem: - Repetition in interrupt configs. We really only have two things: irq containers and element types. Solution: - Consolidate the types. - Preserve the existing interface with aliases.
Problem: - When enabling/disabling a child interrupt, it may or may not be desirable to propagate a possible enable/disable to a parent. Solution: - Allow blocking propagation by policy. - The default is to propagate enables/disables up the tree.
elbeno
force-pushed
the
interrupt-refactor
branch
2 times, most recently
from
35a0089 to
2ea5add
Compare
Problem: - Top-level irqs need (the possibility of) an enable field. Solution: - Add an enable field to top-level irq definitions. Note: - `id_irq` was a hack that did this for a while. - The field can still be `no_field_t` if necessary.
elbeno
force-pushed
the
interrupt-refactor
branch
from
2ea5add to
24d1641
Compare
mjcaisse-intel
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
id_irqis a hack. Where we're going, we don't need it.and element types.
propagate a possible enable/disable to a parent.
Solution:
id_irq.