-
Notifications
You must be signed in to change notification settings - Fork 97
inplace hadamard #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wenhuach21
wants to merge
24
commits into
main
Choose a base branch
from
hadamard_change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
inplace hadamard #1641
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ff91f07
tmp change
wenhuach21 65f7a6f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 267b6a2
o_proj quantization has not been handled
wenhuach21 9609db3
update
wenhuach21 c13d24b
update
wenhuach21 eb3ee0a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f41771c
update
wenhuach21 1455702
Merge branch 'hadamard_change' of https://github.com/intel/auto-round…
wenhuach21 df14371
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e3c1d93
support not using fast hadamard
wenhuach21 02ce508
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a978b4c
update
wenhuach21 d790ce0
update
wenhuach21 936c2f5
support opt-125m by AI, it seems that the accuracy dropped after rota…
wenhuach21 8ca7973
update
wenhuach21 c07b3b1
update
wenhuach21 89516fe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3760a3b
update
wenhuach21 8ac1cee
Merge branch 'hadamard_change' of https://github.com/intel/auto-round…
wenhuach21 ccf8661
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7a7276e
fix
wenhuach21 cb09ae5
Merge branch 'hadamard_change' of https://github.com/intel/auto-round…
wenhuach21 a009d9a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8c1b4f6
Merge branch 'main' into hadamard_change
wenhuach21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # # Copyright (C) 2026 Intel Corporation | ||
| # # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from auto_round.experimental.hadamard_inplace.apply_hadamard_rotation import apply_hadamard_rotation | ||
|
|
||
| # from auto_round.experimental.hadamard_inplace.model_config import ( | ||
| # MAPPING_REGISTRY, | ||
| # RotationMapping, | ||
| # get_mapping, | ||
| # infer_mapping_from_model, | ||
| # register_mapping, | ||
| # ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forces
hadamard_config="default"for every CLI tune run, changing default behavior and (with the current BaseCompressor changes) triggering the hadamard path without actually applying it / initializingself.hadamard_config, which can lead to downstream failures during save/export. Consider making this opt-in via a CLI flag or keep the previous defaultNone.