Completed Job application

github-challenge/README

@@ -0,0 +1,15 @@
+This directory contains script for fetching the most recent Ruby on Rails commits from Github.
+
+Ruby:
+
+  Usage:  ruby rails-commits.rb
+  Prerequisites:	
+    - gem install json
+
+PHP:
+
+  Usage:  php rails-commits.php
+  Prerequisites:
+    - json extension installed & enabled
+    - short tags enabled
+

github-challenge/rails-commits.php

@@ -0,0 +1,18 @@
+<?php
+	$url = "http://github.com/api/v2/json/commits/list/rails/rails/master";
+	$json = json_decode(file_get_contents($url));
+	$data = array();
+	foreach ($json->commits as $commit) {
+		$data[$commit->author->email][] = $commit;
+	}
+	ksort($data);
+?>
+<? foreach ($data as $email => $commits): ?> 
+<h1><?= $commits[0]->author->name . " (" . $email . ")"?></h1>	
+<ul>
+	<? foreach ($commits as $commit): ?>
+	<li><tt><?= $commit->id ?></tt><br/><?= $commit->message ?></li>
+	<? endforeach ?>		
+</ul>
+</pre>
+<? endforeach ?>		

github-challenge/rails-commits.rb

@@ -0,0 +1,24 @@
+require 'net/http'
+require 'uri'
+require 'rubygems'
+require 'json'
+require 'erb'
+
+# REST URI for Ruby on Rails Github repository most recent commits
+url = "http://github.com/api/v2/json/commits/list/rails/rails/master";
+
+# Get the commits from the URL using JSON and group them by author
+data = JSON.parse(Net::HTTP.get(URI.parse(url)))['commits'].group_by { |commit| commit['author'] } 
+
+# Print the HTML using the embedded ERB template
+puts ERB.new(DATA.read).result(binding)
+
+__END__
+<% data.each do |author, commits| %>
+<h1><%= author['name']%> (<%= author['email'] %>)</h1>
+<ul>
+  <% commits.each do |commit| %>
+  <li><%= commit['id'] %><br/><%= commit['message'] %></li>
+  <% end %>
+</ul>
+<% end %>

refactor-this/factories.rb

@@ -7,6 +7,10 @@
   u.email Factory.next(:email)
 end
 
+Factory.define(:user_profile) do |p|
+  p.name "Clayton"
+end
+
 Factory.define(:photo) do |p|
 
 end

refactor-this/helper.rb

@@ -1,67 +1,40 @@
 class Helper
-  def self.foo
-    "foo"
-  end
-
-  def image_size(profile, non_rep_size)
-    if profile.user.rep?
-      '190x114'
-    else
-      non_rep_size
+
+  def profile_path(profile)
+    # FIXME: figure what this should actually be
+    "/path/to/profiles/#{profile.name}" 
+  end
+
+  # Define methods for display_X_photo, where X can be small, medium, large, or huge
+  {:small => '32x32', :medium => '48x48', :large => '64x64', :huge => '200x200'}.each do |name, size|   
+    send :define_method, "display_#{name}_photo" do |*args|
+      profile = args[0]
+      size = '190x119' if profile.user && profile.user.rep?  
+      args = [profile, size, args[1], args[2]]
+      args << true if /large|huge/.match(name.to_s)
+      display_photo(*args)
     end
   end
-
-  def display_small_photo(profile, html = {}, options = {})
-    display_photo(profile, image_size(profile, "32x32"), html, options)
-  end
-
-  def display_medium_photo(profile, html = {}, options = {})
-    display_photo(profile, image_size(profile, "48x48"), html, options)
-  end
-
-  def display_large_photo(profile, html = {}, options = {}, link = true)
-    display_photo(profile, image_size(profile, "64x64"), html, options, link)
-  end
-
-  def display_huge_photo(profile, html = {}, options = {}, link = true)
-    display_photo(profile, image_size(profile, "200x200"), html, options, link)
-  end
-
+
   def display_photo(profile, size, html = {}, options = {}, link = true)
-    return image_tag("wrench.png") unless profile  # this should not happen
+    return image_tag("wrench.png") unless profile  
 
     show_default_image = !(options[:show_default] == false)
-    html.reverse_merge!(:class => 'thumbnail', :size => size, :title => "Link to #{profile.name}")
-
-    if profile && profile.user
-      if profile.user && profile.user.photo && File.exists?(profile.user.photo)
-        @user = profile.user
-        if link
-          return link_to(image_tag(url_for_file_column("user", "photo", size), html), profile_path(profile) )
-        else
-          return image_tag(url_for_file_column("user", "photo", size), html)
-        end
-      else
-        show_default_image ? default_photo(profile, size, {}, link) : ''
+    html.reverse_merge!(:class => 'thumbnail', :size => size, :title => "Link to #{profile.name}") 
+
+    if profile.has_valid_photo?
+      imagefile = url_for_file_column("user", "photo", size)
+    else 
+      if show_default_image && profile.user
+        size = '190x119' if profile.user.rep?
+        html = {} 
+      elsif profile.user
+        return 'NO DEFAULT'
       end
+      imagefile = "user#{size}.jpg"
     end
 
-    show_default_image ? default_photo(profile, size, {}, link) : ''
-  end
-
-  def default_photo(profile, size, html={}, link = true)
-    if link
-      if profile.user.rep?
-        link_to(image_tag("user190x119.jpg", html), profile_path(profile) )
-      else
-        link_to(image_tag("user#{size}.jpg", html), profile_path(profile) )
-      end
-    else
-      if profile.user.rep?
-        image_tag("user190x119.jpg", html)
-      else
-        image_tag("user#{size}.jpg", html)
-      end
-    end
+    img = image_tag(imagefile, html) 
+    return link ? link_to(img, profile_path(profile)) : img
   end
 end