Open
Conversation
nathanmarks
reviewed
Mar 25, 2021
src/styles/themer/ThemerProvider.js
Outdated
| render() { | ||
| const { themer, children } = this.props | ||
| const { tick } = this.state | ||
| return <ThemerContext.Provider value={{ themer, tick }}>{children}</ThemerContext.Provider> |
Collaborator
There was a problem hiding this comment.
technically you don't need to pass tick here, because you're already creating a new object every time this render() method runs, which will happen after you setState. Context doesn't do deep comparisons to determine if the value has changed, it's referential.
dmatteo
previously approved these changes
Mar 25, 2021
dmatteo
left a comment
dmatteo
left a comment
There was a problem hiding this comment.
LGTM tho I think Nathan is correct if you want to remove the tick trick (ha!)
Member
Author
|
published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change
consumers need to hook up the
ThemeProviderto their ownThemerclass reference to get custom themes.the default theme still works out of the box with no change