You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request enhances the testing infrastructure for gcalcli to more accurately simulate Google Calendar API interactions, particularly for the ImportICS functionality.
Key changes include:
Improved Google API Client Mocking: The test utilities (tests/_utils.py and tests/conftest.py) have been updated to faithfully mimic the Google API client's two-step call pattern. This involves methods (like list(), insert(), import_()) returning a request object, which then requires an execute() call to perform the actual API operation. This ensures that tests precisely track which Google API method is invoked.
Enhanced ImportICS Test Accuracy: This improved mocking allows for more accurate verification of gcalcli's ImportICS method, ensuring it correctly dispatches to either the Google Calendar events().import_ or events().insert API based on event properties and the --use-legacy-import flag.
Test Variable Renaming: In tests/test_gcalcli.py, the ics_content variable was renamed to ics_file in relevant ImportICS tests for improved clarity.
These changes provide a more robust testing environment to verify the correct logic for using the import versus insert API, especially in the context of the --use-legacy-import flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #836 (or at least improves it).
This pull request enhances the testing infrastructure for
gcalclito more accurately simulate Google Calendar API interactions, particularly for theImportICSfunctionality.Key changes include:
tests/_utils.pyandtests/conftest.py) have been updated to faithfully mimic the Google API client's two-step call pattern. This involves methods (likelist(),insert(),import_()) returning a request object, which then requires anexecute()call to perform the actual API operation. This ensures that tests precisely track which Google API method is invoked.ImportICSTest Accuracy: This improved mocking allows for more accurate verification ofgcalcli'sImportICSmethod, ensuring it correctly dispatches to either the Google Calendarevents().import_orevents().insertAPI based on event properties and the--use-legacy-importflag.tests/test_gcalcli.py, theics_contentvariable was renamed toics_filein relevantImportICStests for improved clarity.These changes provide a more robust testing environment to verify the correct logic for using the
importversusinsertAPI, especially in the context of the--use-legacy-importflag.