Draft
Conversation
The query only exposes a way to get all mint/burn events for slot as upper bound.
42f3d88 to
6648c3e
Compare
Apparently, I made it myself already in 51fe6ec Add MintBurn indexer (#913)
3f35049 to
54acfe3
Compare
54acfe3 to
8098347
Compare
Contributor
Author
|
@koslambrou @berewt So it looks like I won't be able to finish this ticket. The issue that remains is that redeemer hash and data don't always match between marconi and dbsync (if you set it to Nothing on both marconi and dbsync results then the test succeeds). The funny part being that they sometimes don't match. Might be worth it to double-check the sql query with dbsync team and also and maybe ledger or plutus-core team on whether the redeemer we save is correct. There are How to run the test:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: figuring out redeemers is still in progress, but the rest passes the test.
PLT-5384: Main addition is this test here which:
[TxMintRow]for that slot[TxMintRow]from a preexisting dbsync postgres database for that slot as well. (The sql query to get these from postgres is this one, confirmed correctness of this on cardano-db-sync's slack channel)Managed to find and fix a bug.
This test is meant to be run only manually as there are no pre-existing Marconi nor dbsync databases around in CI. Since the entire cabal component is set to "not buildable" with a flag. To build/run/repl it locally one needs to add
--flag '-ci'to the cabal cli, so for examplecabal build marconi-chain-index-test-compare-cardano-db-sync --flag '-ci'cabal repl marconi-chain-index-test-compare-cardano-db-sync --flag '-ci'cabal run marconi-chain-index-test-compare-cardano-db-sync --flag '-ci'will work.
Pre-submit checklist: