feat: export InsertionMode enum from parse5#1704
Open
TrevorBurnham wants to merge 1 commit intoinikulin:masterfrom
Open
feat: export InsertionMode enum from parse5#1704TrevorBurnham wants to merge 1 commit intoinikulin:masterfrom
TrevorBurnham wants to merge 1 commit intoinikulin:masterfrom
Conversation
43081j
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #531
Summary
Exports the
InsertionModeenum so that consumers building custom parsers can checkinsertionModeagainst named values instead of magic numbers.Changes
packages/parse5/lib/parser/index.ts— Changedenum InsertionModetoexport enum InsertionModewith explicit numeric assignments to guarantee stable values across releases.packages/parse5/lib/index.ts— AddedInsertionModeto the re-export from./parser/index.js.packages/parse5/lib/parser/index.test.ts— Added a smoke test verifying the export exists and key values are stable.Usage