add safe details and safe update-member#230
Open
davidh-cyberark wants to merge 1 commit intoinfamousjoeg:mainfrom
Open
add safe details and safe update-member#230davidh-cyberark wants to merge 1 commit intoinfamousjoeg:mainfrom
davidh-cyberark wants to merge 1 commit intoinfamousjoeg:mainfrom
Conversation
davidh-cyberark
commented
Dec 5, 2024
- add safe details
- add safe update-member
- error string fixes in safes.go
- bump version minor number
- fix add-member example text
|
infamousjoeg
requested changes
Dec 11, 2024
Owner
infamousjoeg
left a comment
There was a problem hiding this comment.
LGTM just missing the updated docs for this.
To update docs and include it in your PR, from within the docs/ directory run:
go run main.go and it will update docs. Commit those here and we're good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


