Add IndexMap::from(array) and IndexSet::from(array)#205
Merged
cuviper merged 2 commits intoindexmap-rs:masterfrom Jan 6, 2022
Merged
Add IndexMap::from(array) and IndexSet::from(array)#205cuviper merged 2 commits intoindexmap-rs:masterfrom
IndexMap::from(array) and IndexSet::from(array)#205cuviper merged 2 commits intoindexmap-rs:masterfrom
Conversation
Contributor
Author
|
I think the CI failure is because of the MSRV… I’m not sure how to handle that. 😕 |
Member
|
Yes, that's expected. We should pick this up as soon as we can. Unsure if using autocfg is a good solution here. |
Contributor
Author
|
@bluss I think I figured out how to use autocfg for this. 🤞 |
Contributor
Author
|
@bluss bumping this now that CI is passing |
cuviper
requested changes
Dec 9, 2021
cuviper
requested changes
Jan 6, 2022
Member
cuviper
left a comment
cuviper
left a comment
There was a problem hiding this comment.
Just some cleanup on the cfgs.
Contributor
Author
Oops, good catch. Fixed! |
This patch adds `IndexMap::from(array)` and `IndexSet::from(array)` to match the API for `HashMap`, `HashSet`, etc. as of rust-lang/rust#84111.
…rray)` rust-lang/rust#74878 and rust-lang/rust#65798 were both stabilized in 1.51.
Member
|
Oh, we do still need |
Contributor
Author
Ah okay. Reverted removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
IndexMap::from(array)andIndexSet::from(array)to match the API forHashMap,HashSet, etc. as of rust-lang/rust#84111.