added typescript type definitions#66
Open
iamdanthedev wants to merge 1 commit intoindexiatech:masterfrom
iamdanthedev:master
Open
added typescript type definitions#66iamdanthedev wants to merge 1 commit intoindexiatech:masterfrom iamdanthedev:master
iamdanthedev wants to merge 1 commit intoindexiatech:masterfrom
iamdanthedev:master
Conversation
kylecesmat
suggested changes
Dec 17, 2018
kylecesmat
left a comment
kylecesmat
left a comment
There was a problem hiding this comment.
Nice work! If you can handle the one comment and then ping me for re-review I can get this merged + tagged!
| "object-assign": "^4.1.1", | ||
| "prop-types": "^15.5.10", | ||
| "react": "^16.2.0", | ||
| "react-dom": "^16.2.0", |
There was a problem hiding this comment.
Remove these from dependencies since they are already required in peerDependencies below with looser ranges :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've been using the library for some time and got tired from importing it in a non-ts fashion, so here are type definitions, they seem to work. Although I've never wrote type defs for js libraries, some review would be appreciated if there is anyone able to do that
Thanks