let the user define a global dismissAfter prop (dismiss is now handled by the component, not the action anymore)#33
Open
Grsmto wants to merge 7 commits intoindexiatech:masterfrom
Open
Conversation
added 7 commits
April 13, 2016 19:17
…d by the component, not the action anymore)
# Conflicts: # demo/index.js # src/actions/notifs.js # src/components/Notifs.js
Grsmto
changed the title
Author
|
:/ |
|
@Grsmto sorry - We can reopen this PR. I assumed it was inactive, my apologies. If you'd like to refresh your branch we can actually merge this. |
Author
|
Ok no worries! Just tell me if you're still interested by the feature and I can update again :p As you want! |
|
@Grsmto I think it's a great feature! This repository has just been dormant so hard to regain context of what is going on. My apologies again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
It doesn't seems like I can re-open the previous PR #8.
I updated the PR with the latest version of Master.
You can test in the demo (just change the dismiss time to any value).
Thanks!