Fix hanging when undoing/committing on an uninitialized notebook#433
Merged
BillyZhaohengLi merged 7 commits intomainfrom Mar 12, 2025
Merged
Fix hanging when undoing/committing on an uninitialized notebook#433BillyZhaohengLi merged 7 commits intomainfrom
BillyZhaohengLi merged 7 commits intomainfrom
Conversation
mIXs222
reviewed
Mar 12, 2025
Collaborator
mIXs222
left a comment
mIXs222
left a comment
There was a problem hiding this comment.
Let's catch the exceptions in jupyterlab_kishu::handlers::subp_kishu_* instead and compose JSON from the exception there. Some other exceptions in core lib could still hang the extension.
The Current idea makes the different commands asymmetric. Better fix at this layer would be making a decorator that catches any exception and wraps it in declared *Result data class. A lot of ugly try-excepts would go away
added 3 commits
March 12, 2025 14:57
BillyZhaohengLi
force-pushed
the
zl20/fix-uninitialized-undo
branch
from
61137ea to
cf1d902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hanging when undoing/committing on an uninitialized notebook. The "Kishu is not initialized" error message shows up instead.
#414