[patch] Fix ibm-operator-catalog app attempting to render with invalid defaults#421
Merged
[patch] Fix ibm-operator-catalog app attempting to render with invalid defaults#421
Conversation
…provided In the absence of any real ibm-operator-catalog.yaml file, the defaults from values.yaml were being used. This caused the application to attempt to render with invalid values and fail.
…log_version is not present
rbinns
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaults in ibm-mas-cluster-root/values.yaml:
cause the ibm-operator-catalog application to render even when there is no ibm-operator-catalog.yaml configuration file present in gitops-envs. Because the defaults do not represent a valid configuration, this results in ArgoCD attempting and failing to sync the application rather than mark it for deletion.
This PR resolves the issue by:
ttps://jsw.ibm.com/browse/MASCORE-12837
Verified that the application still renders as expected when
ibm-operator-catalog.yamlis present:Verified that the application is now correctly marked for deletion when
ibm-operator-catalog.yamlis absent, and the instance and sls appsets are still rendering correctly: