Move the dragging prompt away from being drawn every time the outline…#112
Open
danielpunkass wants to merge 3 commits intoiMediaSandboxing:developmentfrom
Open
Move the dragging prompt away from being drawn every time the outline…#112danielpunkass wants to merge 3 commits intoiMediaSandboxing:developmentfrom
danielpunkass wants to merge 3 commits intoiMediaSandboxing:developmentfrom
Conversation
… view draws, to a separate proper text field subview of the scroll view. This prevents the prompt text from scrolling along with the content, and alleviates problems with stale drawing sticking around sometimes when the scrollview has cached its image.
Author
|
There's something wrong with my pull request, in that adding the prompt as a subview of the scroll view messed up the key view loop. I'm looking into that. |
…te the nextKeyView loop for the view. Just add it once the first time it's needed and rely upon alpha settings to make it invisible when wanted.
Author
|
Should be fixed now. |
iljaiwas
approved these changes
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… view draws, to a separate proper text field subview of the scroll view. This prevents the prompt text from scrolling along with the content, and alleviates problems with stale drawing sticking around sometimes when the scrollview has cached its image.