fix: complete Vert.x 3.9 compatibility (SLF4J logging, async methods, Java 11)#27
Open
shwetaverma14 wants to merge 19 commits intohyphae:mainfrom
Open
fix: complete Vert.x 3.9 compatibility (SLF4J logging, async methods, Java 11)#27shwetaverma14 wants to merge 19 commits intohyphae:mainfrom
shwetaverma14 wants to merge 19 commits intohyphae:mainfrom
Conversation
- Update Java 8 → 11 - Update maven-compiler-plugin 3.1 → 3.11.0 - Replace Vert.x logging with SLF4J - Use callback pattern for async methods Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
shwetaverma14
force-pushed
the
stable-vertx-3.9
branch
from
7503408 to
0f64e58
Compare
added 7 commits
March 24, 2026 21:27
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
- Update all logging to SLF4J - Use callback pattern for async methods - Java 11 and plugin 3.11.0 already in pom.xml Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
- Replace all Vert.x logging with SLF4J - Use callback pattern for async methods - Java 11 and plugin 3.11.0 in pom.xml Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
…rsion Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
axmsoftware
approved these changes
Mar 24, 2026
shwetaverma14
force-pushed
the
stable-vertx-3.9
branch
from
a0b63ec to
2db59f7
Compare
added 10 commits
March 25, 2026 00:00
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
… and imports Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
… pattern Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
…with SLF4J and onComplete Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
shwetaverma14
force-pushed
the
stable-vertx-3.9
branch
from
2db59f7 to
04c39f3
Compare
Signed-off-by: Shweta Verma <shwetaverma14@gmail.com>
shwetaverma14
force-pushed
the
stable-vertx-3.9
branch
from
2301fea to
d02d463
Compare
axmsoftware
approved these changes
Mar 25, 2026
Contributor
|
@shwetaverma14 take a look at the neutral check . I see a lot of unverified pushes that were forced. Please try to resolve. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
io.vertx.core.loggingwithorg.slf4j.onComplete()patternWhy
Testing
✅
mvn clean compilepasses✅
mvn testpasses (3/3 tests)DCO
✅ Signed-off-by included
Related
Fixes #22