Fix runner terminal launch by goyalpalak18 · Pull Request #82 · hyphae/APIS

goyalpalak18 · 2026-01-29T05:56:56Z

Summary

This PR fixes a startup issue in runner.sh where APIS services would fail to launch on Linux systems using KDE Plasma (konsole) or XFCE (xfce4-terminal).

The Problem

The script was attempting to pass compound shell commands (e.g., cd ... && ...) directly to the terminal emulator's execution flag. Unlike GNOME Terminal, both konsole and xfce4-terminal expect a single executable path rather than a shell string. This caused the terminal windows to either close immediately or fail with a "command not found" error, preventing the emulator from starting.

The Solution

I updated the launch logic for both konsole and xfce4-terminal to wrap the commands in a bash -c subshell.

This ensures the directory change and command execution are interpreted correctly by the shell.
I also explicitly added a command to keep the shell session open after execution, ensuring the terminal window remains visible (honoring the intended "hold" behavior).

Verification

To verify this fix:

Use a Linux environment running KDE Plasma or XFCE.
Run make run-apis-emulator.
Result: The terminal window now opens successfully and remains open while the emulator runs, instead of crashing on startup.

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Add initial GOVERNANCE.md Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

…arkdown Add CODE_OF_CONDUCT.md Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Add CONTRIBUTING.MD Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Add initial COMMITTERS.csv file Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

…patch-1 Improve Makefile help target for better contributor guidance Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update README.md Technology spelling Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

…y: Akarsh Sahlot <akarshsahlot8@gmail.com> - Restructure content to match LF Energy CoMPAS format - Move Quick Start section to top for better accessibility - Organize system components into logical groups - Consolidate support and community resources - Add proper badges section - Maintain all essential technical information Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

docs: reorganize README.md to follow LF Energy standards Signed-off-b… Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Create scorecard.yml Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

docs: reorganize README.md to follow LF Energy project standards Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

docs: fix broken links and remove unverified content Remove fictional testimonials, non-existent documentation links, and unverified statistics while maintaining professional structure. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Updated README.md to follow LF Energy CoMPAS format,removed broken links and removed MongoDB as a requirement Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Adjusted permissions and action versions Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update Scorecard workflow dependencies and permissions Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Updated retention days for SARIF file upload and changed CodeQL action version. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Modify scorecard workflow for SARIF retention and version Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Added OpenSSF Scorecard Badge. Removed introductory tagline and image from README. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update README to add OpenSSF Scorecard Badge Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

AkarshSahlot · 2026-02-08T16:42:35Z

@Dipeua have a look o this

WillSams and others added 30 commits February 7, 2025 09:53

Add CONTRIBUTING.md file

bbbbe67

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Lint README.md

9d4b9b3

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Add initial COMMITTERS.csv file

c6fa84f

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

updated git base url, changed from soy to hyphae

fdbe999

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Add CODE_OF_CONDUCT.md

b9a553f

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update CODE_OF_CONDUCT.md

56c1f7c

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Add initial GOVERNANCE.md

f4393fc

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#18 from hyphae/12-doc/add-governance-markdown

eba240f

Add initial GOVERNANCE.md Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#17 from hyphae/11-doc/add-code_of_conduct-m…

088394c

…arkdown Add CODE_OF_CONDUCT.md Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#15 from hyphae/8-chore/add-contributing-file

06d55ee

Add CONTRIBUTING.MD Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#16 from hyphae/10-doc/add-committers-csv

70a5a9b

Add initial COMMITTERS.csv file Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Create scorecard.yml

a7ae489

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update README.md Technology spelling

8102aff

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update Makefile

37181e0

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#49 from hyphae/Venkata-Sai-Vishwanath-robo-…

005eb61

…patch-1 Improve Makefile help target for better contributor guidance Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#47 from Souradip121/add-license-1

5eba244

Update README.md Technology spelling Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update .github/workflows/scorecard.yml

57912f9

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#1 from AkarshSahlot/AkarshSahlot-patch-1

4cd8cea

docs: reorganize README.md to follow LF Energy standards Signed-off-b… Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#37 from hyphae/axmsoftware-patch-2

9ce1cb5

Create scorecard.yml Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#54 from AkarshSahlot/add-license-1

942aa69

docs: reorganize README.md to follow LF Energy project standards Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#57 from AkarshSahlot/patch-1

31746ce

Updated README.md to follow LF Energy CoMPAS format,removed broken links and removed MongoDB as a requirement Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update Scorecard workflow dependencies and permissions

cc73f53

Adjusted permissions and action versions Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#70 from hyphae/axmsoftware-patch-4

39732d8

Update Scorecard workflow dependencies and permissions Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Modify scorecard workflow for SARIF retention and version

abc2444

Updated retention days for SARIF file upload and changed CodeQL action version. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#72 from hyphae/axmsoftware-patch-4-1

a256103

Modify scorecard workflow for SARIF retention and version Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Update README to add OpenSSF Scorecard Badge

74d45e4

Added OpenSSF Scorecard Badge. Removed introductory tagline and image from README. Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Merge pull request hyphae#73 from hyphae/axmsoftware-patch-4-2

bde0bda

Update README to add OpenSSF Scorecard Badge Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

docs: add brief note on Java code quality tooling

c0535c9

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

Fix terminal launch failure on KDE/XFCE Linux desktops

7cace7e

Signed-off-by: Palak Goyal <goyalpalak1806@gmail.com> Co-authored-by: Yatin Jamwal <yatinjamwal07@gmail.com>

goyalpalak18 force-pushed the fix-runner-terminal-launch branch from 0e765d0 to a9d2c6f Compare January 30, 2026 05:01

axmsoftware approved these changes Feb 10, 2026

View reviewed changes

goyalpalak18 force-pushed the fix-runner-terminal-launch branch from a9d2c6f to 7cace7e Compare April 1, 2026 05:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix runner terminal launch#82

Fix runner terminal launch#82
goyalpalak18 wants to merge 31 commits intohyphae:add-license-1from
goyalpalak18:fix-runner-terminal-launch

goyalpalak18 commented Jan 29, 2026

Uh oh!

AkarshSahlot commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

goyalpalak18 commented Jan 29, 2026

Summary

The Problem

The Solution

Verification

Uh oh!

AkarshSahlot commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants