Skip to content

chore: enable manual_is_variant_and and manual_let_else clippy lints#2707

Open
MingweiSamuel wants to merge 2 commits intomainfrom
mingwei/manual-lints
Open

chore: enable manual_is_variant_and and manual_let_else clippy lints#2707
MingweiSamuel wants to merge 2 commits intomainfrom
mingwei/manual-lints

Conversation

@MingweiSamuel
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 2, 2026 22:46
@MingweiSamuel MingweiSamuel changed the title chore: enable manual_is_variant_and and manual_let_else lints chore: enable manual_is_variant_and and manual_let_else clippy lints Apr 2, 2026
@MingweiSamuel MingweiSamuel requested review from shadaj and removed request for Copilot April 2, 2026 22:47
reason = "uninhabited but deploy_integration required at embedded runtime"
)
)]
/// Returns a [`QuotedWithContext`] that references the `__cluster_self_id` runtime variable.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm idk if this was supposed to be removed actually

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep getting warnings recently about the expect not being hit when no features are enabled...

Copilot AI review requested due to automatic review settings April 2, 2026 22:51
@MingweiSamuel MingweiSamuel force-pushed the mingwei/manual-lints branch from fc2e841 to 058f855 Compare April 2, 2026 22:51
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 2, 2026

Deploying hydro with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76b3e53
Status: ✅  Deploy successful!
Preview URL: https://88c398a7.hydroflow.pages.dev
Branch Preview URL: https://mingwei-manual-lints.hydroflow.pages.dev

View logs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables additional Clippy lints (manual_is_variant_and, manual_let_else) at the workspace level and updates several call sites to align with the new lint expectations.

Changes:

  • Turn on manual_is_variant_and and manual_let_else in workspace Clippy lint configuration.
  • Refactor several match / if let patterns into let ... else forms.
  • Remove a conditional expect(unreachable_code) attribute from the embedded runtime helper.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Enables the two new Clippy lints as warn at the workspace level.
hydro_lang/src/viz/json.rs Refactors object extraction to let ... else (currently introduces a move/return issue).
hydro_lang/src/location/cluster.rs Refactors if let into let ... else when extracting Cluster IDs.
hydro_lang/src/deploy/deploy_runtime_containerized.rs Refactors frame reads to let Some(Ok(...)) = ... else { ... } for handshake steps.
hydro_lang/src/deploy/deploy_graph_containerized_ecs.rs Refactors LocationId extraction in loops to let ... else unreachable!().
hydro_lang/src/compile/embedded_runtime.rs Removes a conditional expect(unreachable_code) attribute block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MingweiSamuel MingweiSamuel force-pushed the mingwei/manual-lints branch from 058f855 to 76b3e53 Compare April 3, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants