chore: enable manual_is_variant_and and manual_let_else clippy lints#2707
Open
MingweiSamuel wants to merge 2 commits intomainfrom
Open
chore: enable manual_is_variant_and and manual_let_else clippy lints#2707MingweiSamuel wants to merge 2 commits intomainfrom
manual_is_variant_and and manual_let_else clippy lints#2707MingweiSamuel wants to merge 2 commits intomainfrom
Conversation
manual_is_variant_and and manual_let_else lintsmanual_is_variant_and and manual_let_else clippy lints
MingweiSamuel
commented
Apr 2, 2026
| reason = "uninhabited but deploy_integration required at embedded runtime" | ||
| ) | ||
| )] | ||
| /// Returns a [`QuotedWithContext`] that references the `__cluster_self_id` runtime variable. |
Member
Author
There was a problem hiding this comment.
hmm idk if this was supposed to be removed actually
Member
There was a problem hiding this comment.
I keep getting warnings recently about the expect not being hit when no features are enabled...
fc2e841 to
058f855
Compare
Deploying hydro with
|
| Latest commit: |
76b3e53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88c398a7.hydroflow.pages.dev |
| Branch Preview URL: | https://mingwei-manual-lints.hydroflow.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables additional Clippy lints (manual_is_variant_and, manual_let_else) at the workspace level and updates several call sites to align with the new lint expectations.
Changes:
- Turn on
manual_is_variant_andandmanual_let_elsein workspace Clippy lint configuration. - Refactor several
match/if letpatterns intolet ... elseforms. - Remove a conditional
expect(unreachable_code)attribute from the embedded runtime helper.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Enables the two new Clippy lints as warn at the workspace level. |
hydro_lang/src/viz/json.rs |
Refactors object extraction to let ... else (currently introduces a move/return issue). |
hydro_lang/src/location/cluster.rs |
Refactors if let into let ... else when extracting Cluster IDs. |
hydro_lang/src/deploy/deploy_runtime_containerized.rs |
Refactors frame reads to let Some(Ok(...)) = ... else { ... } for handshake steps. |
hydro_lang/src/deploy/deploy_graph_containerized_ecs.rs |
Refactors LocationId extraction in loops to let ... else unreachable!(). |
hydro_lang/src/compile/embedded_runtime.rs |
Removes a conditional expect(unreachable_code) attribute block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…".infinity/" | head -60
058f855 to
76b3e53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.