Conversation
shadaj
force-pushed
the
sandbox-6489897c-f46d-4de6-806a-d0a72f26a345
branch
from
501ba65 to
52e4586
Compare
Deploying hydro with
|
| Latest commit: |
62bb30f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://71fcd60e.hydroflow.pages.dev |
| Branch Preview URL: | https://sandbox-6489897c-f46d-4de6-8.hydroflow.pages.dev |
shadaj
force-pushed
the
sandbox-6489897c-f46d-4de6-806a-d0a72f26a345
branch
4 times, most recently
from
75dda84 to
62bb30f
Compare
MingweiSamuel
approved these changes
Apr 2, 2026
| &source_port, | ||
| format!("{}_{}", *to_external_key, *to_port_id) | ||
| ), | ||
| parse_quote!(DUMMY), |
Member
There was a problem hiding this comment.
Would be better to represent this as None one day?
Comment on lines
+334
to
+339
| type DylibResult = ( | ||
| Vec<(&'static str, Option<u32>, Dfir<'static>)>, | ||
| Vec<(&'static str, Option<u32>, Dfir<'static>)>, | ||
| Hooks<&'static str>, | ||
| InlineHooks<&'static str>, | ||
| ); |
Member
There was a problem hiding this comment.
worth making an actual struct here? At least add comments per tuple field
Member
Author
There was a problem hiding this comment.
Can't because it's referenced from the generated code.
shadaj
force-pushed
the
sandbox-6489897c-f46d-4de6-806a-d0a72f26a345
branch
from
62bb30f to
ce701dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for external-to-cluster (e2m) and cluster-to-external (m2e) connections in the simulation testing framework.
Changes
e2m_source,e2m_connect, andm2e_sinkmethods to theDeploytrait with defaulttodo!()implementations, and implement them forSimDeploy.compile_networkto handle cluster locations forExternalInputandSendExternalnodes (previouslytodo!()).create_external_source(using a process-level dispatch DFIR graph) andcreate_external_output(tagging with member ID).SimClusterSenderandSimClusterReceivertypes that use a u32 LE prefix wire format for member ID routing.Cluster::sim_input()method that returns aSimClusterSenderand a per-memberStream<T>.Stream::sim_cluster_output()for cluster streams that returns aSimClusterReceiver.sim_cluster_e2m_m2everifying end-to-end cluster sim I/O.Fixes #2690