feat(hydroflow)!: remove import!, fix #1110#1600
Merged
MingweiSamuel merged 5 commits intohydro-project:mainfrom Dec 10, 2024
Merged
feat(hydroflow)!: remove import!, fix #1110#1600MingweiSamuel merged 5 commits intohydro-project:mainfrom
import!, fix #1110#1600MingweiSamuel merged 5 commits intohydro-project:mainfrom
Conversation
shadaj
approved these changes
Dec 7, 2024
Member
shadaj
left a comment
shadaj
left a comment
There was a problem hiding this comment.
Just out of curiosity, what doesn't work on stable?
MingweiSamuel
commented
Dec 7, 2024
Member
Author
|
Basically no good way to resolve relative paths on stable No way to get good diagnostics on external files in general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in prep for rust stable #1587
No good way to resolve the source file paths on stable
No way to get good diagnostics on external files in general, at all
rust-lang/rfcs#3200