feat: create Cargo workspace with crate structure#49
Merged
Bakobiibizo merged 2 commits intorelease-candidatefrom Dec 25, 2025
Merged
feat: create Cargo workspace with crate structure#49Bakobiibizo merged 2 commits intorelease-candidatefrom
Bakobiibizo merged 2 commits intorelease-candidatefrom
Conversation
- Create workspace root Cargo.toml with 5 member crates - Add esrp-core, esrp-canonical, esrp-workspace, esrp-http crates - Add esrp-cli tool in tools directory - Create bindings directories (python, typescript) - Create fixtures directory structure (v1/requests, canonical, responses) - Create tests/conformance directory - Define workspace-level dependencies Closes #1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Reviewer's GuideSets up a Rust Cargo workspace with shared workspace-level metadata and dependencies, introduces skeleton crates and a CLI tool, and updates project docs to reflect the new workspace structure and ticket status. Flow diagram for updated repository directory structuregraph TD
root["Repository_root"]
root --> cargo_toml["Cargo.toml<br/>Workspace_definition"]
root --> crates_dir["crates/"]
root --> tools_dir["tools/"]
root --> bindings_dir["bindings/"]
root --> fixtures_dir["fixtures/"]
root --> tests_dir["tests/"]
root --> docs_dir["docs/"]
subgraph crates["Crates"]
crates_dir --> esrp_core["esrp_core/"]
crates_dir --> esrp_canonical["esrp_canonical/"]
crates_dir --> esrp_http["esrp_http/"]
crates_dir --> esrp_workspace["esrp_workspace/"]
end
subgraph tools["Tools"]
tools_dir --> esrp_cli["esrp_cli/"]
end
subgraph bindings["Language_bindings"]
bindings_dir --> py["python/"]
bindings_dir --> ts["typescript/"]
end
subgraph fixtures["Fixtures"]
fixtures_dir --> fx_v1["v1/"]
fx_v1 --> fx_requests["requests/"]
fx_v1 --> fx_canonical["canonical/"]
fx_v1 --> fx_responses["responses/"]
end
subgraph tests["Tests"]
tests_dir --> conf["conformance/"]
end
subgraph docs["Documentation"]
docs_dir --> tickets["tickets/"]
tickets --> t000["000_index.md"]
tickets --> t001["001_create_cargo_workspace.md"]
end
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The workspace-level dependency list is quite broad for an initial scaffold (e.g., axum, reqwest, tower-http, tokio with
full); consider adding only what the current crates actually need to keep compile times and upgrade surface area smaller. - The status of ticket 001 is now marked as
[~]in000-index.mdwhile CLAUDE.md still shows it as "In Progress" with remaining tasks; it would be helpful to align these status markers before merging so project planning stays consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The workspace-level dependency list is quite broad for an initial scaffold (e.g., axum, reqwest, tower-http, tokio with `full`); consider adding only what the current crates actually need to keep compile times and upgrade surface area smaller.
- The status of ticket 001 is now marked as `[~]` in `000-index.md` while CLAUDE.md still shows it as "In Progress" with remaining tasks; it would be helpful to align these status markers before merging so project planning stays consistent.
## Individual Comments
### Comment 1
<location> `docs/tickets/000-index.md:47-49` </location>
<code_context>
### Phase 0: Repository Setup
-- [ ] [001 - Create Cargo Workspace](001-create-cargo-workspace.md)
+- [~] [001 - Create Cargo Workspace](001-create-cargo-workspace.md)
- [ ] [002 - Initialize Git Repository](002-initialize-git-repository.md)
</code_context>
<issue_to_address>
**suggestion:** Nonstandard `[~]` checkbox may not render or parse correctly in Markdown task lists.
This entry uses `[~]` instead of the standard `[ ]` / `[x]` used elsewhere. If you need an "in progress" state, either document this convention or use a standard checkbox plus status text so Markdown task list rendering and any parsing tools remain consistent.
```suggestion
### Phase 0: Repository Setup
- [ ] [001 - Create Cargo Workspace](001-create-cargo-workspace.md) _(in progress)_
- [ ] [002 - Initialize Git Repository](002-initialize-git-repository.md)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
47
to
49
| ### Phase 0: Repository Setup | ||
| - [ ] [001 - Create Cargo Workspace](001-create-cargo-workspace.md) | ||
| - [~] [001 - Create Cargo Workspace](001-create-cargo-workspace.md) | ||
| - [ ] [002 - Initialize Git Repository](002-initialize-git-repository.md) |
There was a problem hiding this comment.
suggestion: Nonstandard [~] checkbox may not render or parse correctly in Markdown task lists.
This entry uses [~] instead of the standard [ ] / [x] used elsewhere. If you need an "in progress" state, either document this convention or use a standard checkbox plus status text so Markdown task list rendering and any parsing tools remain consistent.
Suggested change
| ### Phase 0: Repository Setup | |
| - [ ] [001 - Create Cargo Workspace](001-create-cargo-workspace.md) | |
| - [~] [001 - Create Cargo Workspace](001-create-cargo-workspace.md) | |
| - [ ] [002 - Initialize Git Repository](002-initialize-git-repository.md) | |
| ### Phase 0: Repository Setup | |
| - [ ] [001 - Create Cargo Workspace](001-create-cargo-workspace.md) _(in progress)_ | |
| - [ ] [002 - Initialize Git Repository](002-initialize-git-repository.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Summary by Sourcery
Set up a Rust Cargo workspace for the ESRP project with multiple crates and a CLI tool, and align documentation to track this workspace initialization work.
New Features:
Enhancements: