fix: delete tile shape verifier helper, inplaced by validshape check#465
Open
FangRui0 wants to merge 1 commit intohw-native-sys:mainfrom
Open
fix: delete tile shape verifier helper, inplaced by validshape check#465FangRui0 wants to merge 1 commit intohw-native-sys:mainfrom
FangRui0 wants to merge 1 commit intohw-native-sys:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the verifyTileBufSameShapeAndElem function into verifyTileBufSameElemType by removing the internal shape equality check. All call sites across numerous operations have been updated to reflect this change. Feedback suggests that the verifyVecTileBinaryOp static function appears to be unused dead code and should be removed to improve maintainability.
Comment on lines
+2355
to
2357
| if (failed(verifyTileBufSameElemType(op, src0Ty, src1Ty, "src0", "src1")) || | ||
| failed(verifyTileBufSameElemType(op, src0Ty, dstTy, "src0", "dst"))) | ||
| return failure(); |
There was a problem hiding this comment.
在您重构此部分代码时，我注意到整个 verifyVecTileBinaryOp 函数似乎在此文件中未被使用。由于它是一个 static 函数，这很可能是可以移除的死代码，以提高代码的可维护性。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题来源： https://gitcode.com/cann/pto-as/issues/11
pto-isa中仅对validshape做检查，pto-as与其对齐
修复方式：
删除通用verify helper中对logical shape的检查，保留valideshape的检查，valideshape的检查通常没有common约束，散布在各个op的verify函数中