Skip to content

Sharing logs via slog#84

Draft
hugelgupf wants to merge 1 commit intomainfrom
slog
Draft

Sharing logs via slog#84
hugelgupf wants to merge 1 commit intomainfrom
slog

Conversation

@hugelgupf
Copy link
Owner

Kinda ugly

@hugelgupf hugelgupf force-pushed the slog branch 4 times, most recently from a6295f6 to b5a6486 Compare January 14, 2024 06:01
@codecov
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (dc645ed) 69.34% compared to head (d947b8b) 69.65%.

Files Patch % Lines
qemu/qslog/slog.go 76.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   69.34%   69.65%   +0.31%     
==========================================
  Files          18       19       +1     
  Lines        1021     1071      +50     
==========================================
+ Hits          708      746      +38     
- Misses        252      262      +10     
- Partials       61       63       +2     
Flag Coverage Δ
amd64-1.21.x 69.28% <77.35%> (+0.32%) ⬆️
arm-1.21.x 69.09% <77.35%> (+0.33%) ⬆️
arm64-1.21.x 69.09% <77.35%> (+0.33%) ⬆️
riscv64-1.21.x 68.16% <77.35%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf force-pushed the slog branch 2 times, most recently from 7733b32 to 9a3c36f Compare January 15, 2024 02:16
Signed-off-by: Chris Koch <chrisko@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant