Skip to content

Develop #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6-keem merged 2 commits into from
Feb 16, 2025
Merged

Develop #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440c591
refactor: remove comment
6-keem Feb 16, 2025
917ac57
fix: Resolve NaN error
6-keem Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ManifestV3Export } from '@crxjs/vite-plugin';

const manifest = {
manifest_version: 3,
name: 'HSU 돋부기',
name: 'HSU 돋부기 🔎',
version: '2.1.4',
description: '한성대학교 LMS 강의, 과제, 퀴즈를 한 눈에!',
action: {},
Expand Down
7 changes: 1 addition & 6 deletions src/hooks/useCourseData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,5 @@ export function useCourseData(courses: any[]) {
});
}
}, [courses, updateData]);

useEffect(() => {
console.log(vods);
}, [vods]);

return { vods, assigns, quizes, isPending, remainingTime, refreshTime, updateData, setIsPending };
return { vods, assigns, quizes, isPending, remainingTime, refreshTime, updateData, setIsPending };
}
2 changes: 1 addition & 1 deletion src/hooks/useGetCourse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const useGetCourses = (): UseCouresResult => {
const data = courseData
.map((div) => {
const label = div.querySelector('.label .label-course')?.textContent?.trim() || null;
if (label && label !== '커뮤니티') return null;
if (!label || label === '커뮤니티') return null;
const a = div.querySelector('a');
const url = new URL((a as HTMLAnchorElement).href);
const urlParams = new URLSearchParams(url.search);
Expand Down
8 changes: 4 additions & 4 deletions src/option/SummaryCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ export default function SummaryCard() {

return (
<Link to={link}>
<Card className="w-full shadow-sm hover:shadow-lg transition-all duration-300 cursor-pointer transform hover:-translate-y-1 pt-0">
<Card className="w-full h-full shadow-sm hover:shadow-lg transition-all duration-300 cursor-pointer transform hover:-translate-y-1 pt-0">
<CardHeader className="flex flex-row items-center justify-between space-y-0 pb-2">
<h3 className="font-semibold text-sm text-muted-foreground">{title}</h3>
{icon}
</CardHeader>
<CardContent>
<CardContent className='h-full'>
{title.includes('퀴즈') ? (
<div className="text-2xl font-bold">{data.length > 0 ? `${total} 개` : '0 개'}</div>
) : (
Expand All @@ -49,8 +49,8 @@ export default function SummaryCard() {
) : (
<Progress value={percentage} className={clsx('h-2 mt-2')} indicatorColor={bgColorClass} />
)}
<p className="text-xs text-muted-foreground mt-2">
{title.includes('퀴즈') ? '직접 확인' : percentage + '% 완료'}
<p className={`text-xs text-muted-foreground mt-2`}>
{title.includes('퀴즈') ? '직접 확인' : isNaN(percentage) ? 0 + '% 완료' : percentage + '% 완료'}
</p>
</CardContent>
</Card>
Expand Down