This repository was archived by the owner on May 27, 2025. It is now read-only.
Open
Conversation
reidpr
suggested changes
Sep 23, 2024
Collaborator
reidpr
left a comment
reidpr
left a comment
There was a problem hiding this comment.
Good job Angelica. A couple suggestions in-line.
lib/filesystem.py
Outdated
Comment on lines
+1297
to
+1288
| # While support for storage v1 was dropped some time ago, let’s at least | ||
| # retain the ability to recognize it. | ||
| if (not os.path.isfile(self.version_file)): | ||
| return 1 | ||
| ch.FATAL('Expected file "%s" not found' % self.version_file) |
Collaborator
There was a problem hiding this comment.
What if we instead omit this whole check, and add the version file to valid_p per #1147, which you would then add to this PR?
Co-authored-by: Reid Priedhorsky <reidpr@lanl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1683