Skip to content

docs: view updated terms#2

Merged
markholdex merged 13 commits intomainfrom
docs/agreement-updates
Apr 1, 2026
Merged

docs: view updated terms#2
markholdex merged 13 commits intomainfrom
docs/agreement-updates

Conversation

@zolotokrylin
Copy link
Copy Markdown
Member

@zolotokrylin zolotokrylin commented Apr 1, 2026

Summary by CodeRabbit

  • Documentation

    • Released Standard Terms v1.1.0: added Data Protection & Information Security, tightened termination-for-cause and audit rights
    • Added Work Order governance: rejection/cure, deemed acceptance, and 30-day invoice submission rules
    • Updated IP, Prior Inventions disclosure, confidentiality duration, mutual indemnities, and narrowed non-solicitation
    • Added Monthly Hours Cap and subcontracting approval controls to Retainer terms
  • Chores

    • Switched documentation to three-part semantic versioning and updated release/process examples

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Warning

Rate limit exceeded

@zolotokrylin has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 5 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 5 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2c61b759-81eb-4294-8dd7-9521a70109fb

📥 Commits

Reviewing files that changed from the base of the PR and between 420d363 and a452480.

📒 Files selected for processing (1)
  • .github/workflows/lint.yml

Walkthrough

Updated versioning and release docs to semantic three-part tags (v1.1.0); expanded Standard Terms with Data Protection, Audit Right, Subcontracting limits, Engagement/Retainer controls, Prior Inventions workflow, revised IP/confidentiality/indemnity/non-solicit/termination clauses; Special Terms template adds Monthly Hours Cap and Prior Inventions schedule; CI lint workflow renamed and consolidated.

Changes

Cohort / File(s) Summary
Release & Versioning
CHANGELOG.md, README.md
Bumped changelog to v1.1.0; README switched examples and release/tagging instructions to three-part semantic tags (vMAJOR.MINOR.PATCH), updated artifact naming and email subject placeholders.
Contract Terms & Templates
STANDARD_TERMS.md, SPECIAL_TERMS.md
Large substantive changes: added Data Protection & Info Security, Audit Right, Subcontracting restrictions, Monthly Hours Cap/Retainer controls, Rejection & Cure workflow, Invoice submission deadlines, Termination for Cause, Prior Inventions schedule; revised Confidential Information duration, IP carve-outs/licensing, indemnification mutuality, and non-solicitation scope. Special Terms template updated to include Monthly Hours Cap and Prior Inventions table.
CI / Checks workflow
.github/workflows/lint.yml
Renamed job to checks, consolidated markdown/link checks into a single job, switched runtime setup to bun, adjusted composite action flags, and excluded node_modules from link checking.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'docs: view updated terms' is vague and doesn't clearly convey what was actually updated in the changeset. Use a more specific title that describes the main changes, such as 'docs: update contractor terms v1.1.0 with IP, data protection, and termination clauses' or 'docs: release Standard and Special Terms v1.1.0'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/agreement-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zolotokrylin zolotokrylin requested a review from markholdex April 1, 2026 04:57
@holdex
Copy link
Copy Markdown

holdex bot commented Apr 1, 2026

Time Submission Status

Member Status Time Action Last Update
zolotokrylin ✅ Submitted 3h 30min Update time Apr 1, 2026, 10:40 AM
markholdex ✅ Submitted 35min Update time Apr 1, 2026, 10:40 AM

You can submit time with the command. Example:

@holdex pr submit-time 15m

See available commands to help comply with our Guidelines.

@zolotokrylin zolotokrylin marked this pull request as ready for review April 1, 2026 04:57
@zolotokrylin
Copy link
Copy Markdown
Member Author

@holdex pr submit-time 3.5h

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
CHANGELOG.md (1)

28-28: Style: hyphenate "open source" when used as compound adjective.

Static analysis correctly suggests hyphenating "open-source" when it modifies a noun ("open-source materials"). Same issue appears in STANDARD_TERMS.md lines 276 and 279.

📝 Proposed hyphenation fix
-  materials that would restrict the Company's use, and that the Contractor has full
+  materials that would restrict the Company's use, and that the Contractor has full

Apply similar fix to STANDARD_TERMS.md:

  • Line 276: "open source materials" → "open-source materials"
  • Line 279: "open source code" → "open-source code"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` at line 28, Edit the sentence containing "Work Product is
original, contains no unlicensed third-party or open source" to hyphenate the
compound adjective—change "open source" to "open-source"; likewise update the
phrases in STANDARD_TERMS.md referenced as "open source materials" and "open
source code" (lines noted in the review) to "open-source materials" and
"open-source code" respectively so the compound adjective is hyphenated
consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@SPECIAL_TERMS.md`:
- Around line 104-105: Edit SPECIAL_TERMS.md to remove the "Hourly" option from
the Work Order Payment Type line: change the line that currently reads "Payment
Type: [Per-Project / Milestone-Based / Hourly]" so it only lists "Per-Project /
Milestone-Based" (retain the surrounding brackets and formatting), leaving the
Agreement header ("Agreement: [Contractor Full Name] — Special Terms v[X.Y.Z] /
Standard Terms v[X.Y.Z]") unchanged.

---

Nitpick comments:
In `@CHANGELOG.md`:
- Line 28: Edit the sentence containing "Work Product is original, contains no
unlicensed third-party or open source" to hyphenate the compound
adjective—change "open source" to "open-source"; likewise update the phrases in
STANDARD_TERMS.md referenced as "open source materials" and "open source code"
(lines noted in the review) to "open-source materials" and "open-source code"
respectively so the compound adjective is hyphenated consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1b36d13-3af1-4ccf-b022-84e5e88ec9ec

📥 Commits

Reviewing files that changed from the base of the PR and between b142f57 and 4f5754b.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • README.md
  • SPECIAL_TERMS.md
  • STANDARD_TERMS.md

Comment on lines +104 to +105
Agreement: [Contractor Full Name] — Special Terms v[X.Y.Z] / Standard Terms v[X.Y.Z]
Payment Type: [Per-Project / Milestone-Based / Hourly]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check how Hourly/Retainer payment types are used across engagement modes

echo "=== Work Order references in STANDARD_TERMS.md ==="
rg -n -C3 'Work Order' STANDARD_TERMS.md | head -40

echo -e "\n=== Engagement Mode definitions ==="
rg -n -C5 'Engagement Mode' STANDARD_TERMS.md

echo -e "\n=== Payment Type references ==="
rg -n -C3 'Payment Type' STANDARD_TERMS.md SPECIAL_TERMS.md

Repository: holdex/contractor-terms

Length of output: 5354


Remove "Hourly" from the Work Order Payment Type options in SPECIAL_TERMS.md line 105.

Work Orders apply only to Project/Milestone engagements. Hourly billing applies exclusively to Retainer engagements, which don't use Work Orders. Keep Payment Type to: [Per-Project / Milestone-Based].

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@SPECIAL_TERMS.md` around lines 104 - 105, Edit SPECIAL_TERMS.md to remove the
"Hourly" option from the Work Order Payment Type line: change the line that
currently reads "Payment Type: [Per-Project / Milestone-Based / Hourly]" so it
only lists "Per-Project / Milestone-Based" (retain the surrounding brackets and
formatting), leaving the Agreement header ("Agreement: [Contractor Full Name] —
Special Terms v[X.Y.Z] / Standard Terms v[X.Y.Z]") unchanged.

@zolotokrylin
Copy link
Copy Markdown
Member Author

Problem: holdex/github-actions creates the node_modules folder

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/lint.yml:
- Around line 22-30: The markdown link-scan currently uses the glob '**/*.md'
which also matches vendored docs under the .holdex-actions directory; update the
scan glob in .github/workflows/lint.yml to explicitly exclude that directory
(e.g., add a negated pattern for .holdex-actions/** or .holdex-actions/**/*.md)
so the step that uses the '**/*.md' pattern does not traverse .holdex-actions;
ensure any other similar glob in the file (around the other scan at lines 37–45)
is updated the same way.
- Around line 22-24: Replace the mutable action ref in the workflow by pinning
the action in the uses: field to the provided commit SHA instead of `@main`;
specifically update the uses value that references
holdex/github-actions/.github/actions/base/checkout@main to use the full commit
SHA (the same SHA currently passed as the ref input) so the action version is
immutable rather than relying on the ref: input.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 50e3a3ea-7d68-4614-9a33-8865a9a3f79d

📥 Commits

Reviewing files that changed from the base of the PR and between 4f5754b and 420d363.

📒 Files selected for processing (2)
  • .github/workflows/lint.yml
  • README.md
✅ Files skipped from review due to trivial changes (1)
  • README.md

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Vadim <vadim@holdex.io>
Signed-off-by: Vadim <vadim@holdex.io>
@markholdex
Copy link
Copy Markdown

@holdex pr submit-time 35m

@markholdex markholdex merged commit a9957e6 into main Apr 1, 2026
4 checks passed
@markholdex markholdex deleted the docs/agreement-updates branch April 1, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants