Add request_to_file to HTTP contract for streaming downloads to disk#169
Merged
Add request_to_file to HTTP contract for streaming downloads to disk#169
Conversation
Add a new `request_to_file` callback to `hex_http` that streams the HTTP response body directly to a file, avoiding loading the full body into memory. Add `get_tarball_to_file/4` and `get_docs_to_file/4` to `hex_repo` that use the new callback to download tarballs and docs directly to disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
request_to_filecallback tohex_httpthat streams the HTTP response body directly to a file, avoiding loading the full body into memory.Add
get_tarball_to_file/4andget_docs_to_file/4tohex_repothat use the new callback to download tarballs and docs directly to disk.