Switched probe-rs to be resolved as a bazel host side executable and not a part of target resolution#8
Open
ngraf3255 wants to merge 3 commits intohexdae:mainfrom
Conversation
…not a part of target resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where flash rules are not compatible with
@platforms//os:nonedue to requiring a host to runprobe-rs. Reason for this change is as follows:I have networking library dependency used in an embedded firmware release. This library builds for both POSIX platforms and for smoltcp based embedded networking. To do so, it uses the
@platforms//osplatform to configure the build. Due to the probe-rs ruleset being anative_binaryit requires a host to run on.Realisically the ELF should be built for the embedded target (and be selectable with the
--platformskey), while probe-rs should be selected for the host. The following steps were done to acomplish this: