Accept CrateGroupInfo in proc_macro_deps filtering#8
Closed
walter-zeromatter wants to merge 1 commit intohermeticbuild:mainfrom
Closed
Accept CrateGroupInfo in proc_macro_deps filtering#8walter-zeromatter wants to merge 1 commit intohermeticbuild:mainfrom
walter-zeromatter wants to merge 1 commit intohermeticbuild:mainfrom
Conversation
filter_deps previously only checked for CrateInfo in proc_macro_deps, causing CrateGroupInfo providers to be silently dropped. This fix accepts CrateGroupInfo alongside CrateInfo, matching the behavior already present for regular deps.
walter-zeromatter
force-pushed
the
pr/filter-deps-fix
branch
from
1fec00d to
217cda7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_depsinutils.bzlpreviously only checked forCrateInfoinproc_macro_deps, silently droppingCrateGroupInfoprovidersCrateGroupInfoalongsideCrateInfo, matching the behavior already present for regular deps