Skip to content

Gitlab add groups support#1041

Merged
yxxhero merged 3 commits intohelmfile:mainfrom
askripe:gitlab-add-groups-support
Mar 5, 2026
Merged

Gitlab add groups support#1041
yxxhero merged 3 commits intohelmfile:mainfrom
askripe:gitlab-add-groups-support

Conversation

@askripe
Copy link
Contributor

@askripe askripe commented Mar 4, 2026

No description provided.

@askripe askripe force-pushed the gitlab-add-groups-support branch 3 times, most recently from 9f0208b to 7e731fe Compare March 4, 2026 11:11
@yxxhero yxxhero requested a review from Copilot March 4, 2026 11:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitLab group CI/CD variable support to the existing GitLab provider by extending the reference path format and updating the documentation accordingly.

Changes:

  • Add buildURL helper to support host/groups/<id>/<var> in addition to legacy project references.
  • Update GitLab provider docs in README.md with group/project examples and an expanded syntax description.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
pkg/providers/gitlab/gitlab.go Adds URL construction logic that dispatches between projects vs groups based on the key path format.
README.md Documents the new GitLab reference formats and provides examples for project and group variables.
Comments suppressed due to low confidence (1)

pkg/providers/gitlab/gitlab.go:102

  • ssl_verify handling is inverted for tls.Config.InsecureSkipVerify: when ssl_verify=true (the default), this currently sets InsecureSkipVerify to true, which disables certificate verification. Flip the boolean (or rename the config/field) so that ssl_verify=false is the only case that skips verification.
	tr := &http.Transport{
		TLSClientConfig: &tls.Config{InsecureSkipVerify: p.SSLVerify},
	}

@askripe askripe force-pushed the gitlab-add-groups-support branch from ce571d1 to ffe671a Compare March 4, 2026 12:52
@yxxhero
Copy link
Member

yxxhero commented Mar 4, 2026

@askripe please fix DCO issue

askripe and others added 3 commits March 4, 2026 15:16
Signed-off-by: Alexander Kulikov <askripe@gmail.com>
Clarified GitLab secrets section with examples for project and group variables.

Signed-off-by: Alexander Kulikov <askripe@gmail.com>
Signed-off-by: Alexander Kulikov <askripe@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@askripe askripe force-pushed the gitlab-add-groups-support branch from ffe671a to 42a84a7 Compare March 4, 2026 13:16
@yxxhero yxxhero merged commit 059eb8a into helmfile:main Mar 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants