Merged
Conversation
9f0208b to
7e731fe
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GitLab group CI/CD variable support to the existing GitLab provider by extending the reference path format and updating the documentation accordingly.
Changes:
- Add
buildURLhelper to supporthost/groups/<id>/<var>in addition to legacy project references. - Update GitLab provider docs in
README.mdwith group/project examples and an expanded syntax description.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
pkg/providers/gitlab/gitlab.go |
Adds URL construction logic that dispatches between projects vs groups based on the key path format. |
README.md |
Documents the new GitLab reference formats and provides examples for project and group variables. |
Comments suppressed due to low confidence (1)
pkg/providers/gitlab/gitlab.go:102
ssl_verifyhandling is inverted fortls.Config.InsecureSkipVerify: whenssl_verify=true(the default), this currently setsInsecureSkipVerifyto true, which disables certificate verification. Flip the boolean (or rename the config/field) so thatssl_verify=falseis the only case that skips verification.
tr := &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: p.SSLVerify},
}
ce571d1 to
ffe671a
Compare
Member
|
@askripe please fix DCO issue |
Signed-off-by: Alexander Kulikov <askripe@gmail.com>
Clarified GitLab secrets section with examples for project and group variables. Signed-off-by: Alexander Kulikov <askripe@gmail.com>
Signed-off-by: Alexander Kulikov <askripe@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ffe671a to
42a84a7
Compare
yxxhero
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.