Skip to content

feat: add pre-release flag to GitHub releases#580

Open
yishaynaPalo wants to merge 2 commits intohelm:mainfrom
yishaynaPalo:feature/add-pre-release-flag
Open

feat: add pre-release flag to GitHub releases#580
yishaynaPalo wants to merge 2 commits intohelm:mainfrom
yishaynaPalo:feature/add-pre-release-flag

Conversation

@yishaynaPalo
Copy link

This change adds the ability to mark GitHub releases as pre-releases by:

  • Adding a new 'pre-release' flag to the upload command
  • Updating the configuration to support the pre-release option
  • Implementing the pre-release flag in the GitHub release creation
  • Adding tests for the pre-release functionality
  • Updating documentation in README.md

This change adds the ability to mark GitHub releases as pre-releases by:
- Adding a new 'pre-release' flag to the upload command
- Updating the configuration to support the pre-release option
- Implementing the pre-release flag in the GitHub release creation
- Adding tests for the pre-release functionality
- Updating documentation in README.md

Signed-off-by: Yishay Nadav <ynadav@paloaltonetworks.com>
@yishaynaPalo yishaynaPalo force-pushed the feature/add-pre-release-flag branch from 1c186d1 to 4d44b7c Compare December 15, 2025 23:30
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the --make-release-latest and that is default to true we need to make sure if we set the pre-release the latest is disabled and log that, also need to add a check if both is set to exit and error out
as you cannot have pre-release and latest at the same time

@cpanato
Copy link
Member

cpanato commented Dec 29, 2025

also this PR is similar to #468

@yishaynaPalo yishaynaPalo force-pushed the feature/add-pre-release-flag branch from 5e84f37 to ff12b1a Compare December 30, 2025 07:08
… both are explicitly enabled

Signed-off-by: Yishay Nadav <ynadav@paloaltonetworks.com>
@yishaynaPalo yishaynaPalo force-pushed the feature/add-pre-release-flag branch from ff12b1a to ad37229 Compare December 30, 2025 07:11
@yishaynaPalo yishaynaPalo requested a review from cpanato December 30, 2025 07:13
@yishaynaPalo
Copy link
Author

@cpanato
I’ve addressed all the comments. I’d appreciate it if you could re-review my MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants