Open
Conversation
jeffgrunewald
approved these changes
Oct 30, 2024
bbalser
approved these changes
Oct 31, 2024
michaeldjeffrey
force-pushed
the
mj/radio_location_esimates_with_hexes
branch
from
f0e0592 to
96df87b
Compare
jeffgrunewald
approved these changes
Nov 1, 2024
Contributor
jeffgrunewald
left a comment
jeffgrunewald
left a comment
There was a problem hiding this comment.
Per my comment on the the correlation event message, I guess the radio_location_estimate_v1 message type is doing exactly what I was asking for, so I guess my real question is really "do the list of correlation events attached to an estimate really provide any value?" such that they belong in this public data structure. They have no meaning to anyone outside of the private backend that processed the location estimate so they just seem like noise here.
macpie
approved these changes
Nov 4, 2024
michaeldjeffrey
force-pushed
the
mj/radio_location_esimates_with_hexes
branch
from
96df87b to
2310830
Compare
macpie
approved these changes
Nov 4, 2024
we use hexes in many places in the system, let's conform to that here as well
Enumerating all the possible valid hexes for a location estimate can create extremely large messages for estimates with large radius. Sending the center hex and grid distance does a few things. - Compacts the message - speaks in terms of hexes like most other things in the system - Provides an easy way to check locations using h3.grid_distance(center, target) <= grid_distance
At this time, the most imformation we can expose about the events that led to the radio location estimate is an id and timestamp. There may be more information in the future, but this is enough information for someone to give us and we can fetch the underlying record for investigation.
This are stored in a table that can be fetched by the entity_id
michaeldjeffrey
force-pushed
the
mj/radio_location_esimates_with_hexes
branch
from
2f2188a to
acc47b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension of #419 that changes (lat,lon,radius) to a res12 hex and grid distance of allowed locations.