Add boosted_hex_device_type_v1 for HIP-109#401
Open
michaeldjeffrey wants to merge 3 commits intomasterfrom
Open
Add boosted_hex_device_type_v1 for HIP-109#401michaeldjeffrey wants to merge 3 commits intomasterfrom
boosted_hex_device_type_v1 for HIP-109#401michaeldjeffrey wants to merge 3 commits intomasterfrom
Conversation
andymck
reviewed
May 8, 2024
devilish66694
approved these changes
Jun 25, 2024
michaeldjeffrey
force-pushed
the
mj/hip-109-boost-by-device-type
branch
from
fc0da24 to
7e0c821
Compare
The first iteration of HIP-109[1] adds the ability to boost by a device type. Pre-existing boosts will continue to boost _all_ device types. From the way the HIP reads, at some point, a hex may be boosted by the same provider for multiple device types. It was undecided wether that would be implemented as multiple device_types attached to a boosted hex, or multiple instances of a boosted hex. [1]: https://github.com/helium/HIP/blob/main/0109-hex-boosting-by-deployment.md
Familiarizes the reader with the context of what they're about to get into.
michaeldjeffrey
force-pushed
the
mj/hip-109-boost-by-device-type
branch
from
4654fc8 to
dcf951f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first iteration of HIP-1091 adds the ability to boost by a device type. Pre-existing boosts will continue to boost all device types.
From the way the HIP reads, at some point, a hex may be boosted by the same provider for multiple device types. It was undecided wether that would be implemented as multiple device_types attached to a boosted hex, or multiple instances of a boosted hex.