Updating comment for invalidated_radio_threshold_report_req_v1 timestamp#394
Open
riobah wants to merge 1 commit intohelium:masterfrom
Open
Updating comment for invalidated_radio_threshold_report_req_v1 timestamp#394riobah wants to merge 1 commit intohelium:masterfrom
riobah wants to merge 1 commit intohelium:masterfrom
Conversation
…amp - it is seconds, not milliseconds
The comment states the `timestamp` field of `invalidated_radio_threshold_report_req_v1` message is in milliseconds but the data shows that it is in seconds:
```
verified_invalidated_radio_threshold_ingest_report_v1 {
status: 0,
timestamp: 1709986943271n,
report: invalidated_radio_threshold_ingest_report_v1 {
receivedTimestamp: 1709986005909n,
report: invalidated_radio_threshold_report_req_v1 {
cbsdId: '',
hotspotPubkey: <Buffer 04 01 03 01 00 b4 f5 e0 a9 e9 49 ae 51 42 bc f5 b6 5e 1b d7 fb ef 87 14 ad 85 00 40 b4 17 b6 24 9c 6e a4 76 28 fd 0b d0 49 41 54 2f 32 c2 c5 f4 93 90 ... 214 more bytes>,
reason: 0,
timestamp: 1709985995n,
carrierPubKey: <Buffer 01 9e 2e 85 d5 8c c4 d7 d9 4c ae 87 45 ae c6 bd fc 9b e6 0f bd 2f da bf 37 e3 38 4d 6c 9f 58 09 1a>,
signature: Uint8Array(0) []
}
}
}
```
devilish66694
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment states the
timestampfield ofinvalidated_radio_threshold_report_req_v1message is in milliseconds but the data shows that it is in seconds: