Merged
Conversation
- protected Sheet sheet 필드 제거 (SXSSFExporter) - 재정의한 write을 final로 변경 - 기존 Sheet생성 + Header 생성 메서드 -> Sheet 생성을 구체 클래스로 이동, Header생성 메서드만 추상클래스에서 정의. - SXSSFExporter 변경에 따른 인터페이스와 구현체 변경
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Release Pull Request
📦 Release Version
v0.0.3✨ Changes Summary
SXSSFExporter) 전역 변수로 선언된 Sheet를 제거 -> method의 인자로 받게 수정SXSSFExporter) write메서드를 final로 변경SXSSFExporter) 기존 새 sheet를 생성하고 header도 생성하는 createHeaderWithNewSheet 메서드의 역화을 분활SXSSFExporter에서 정의DefaultExcelExporter(구현클래스)에서 정의🔗 Related Issues / PRs