Skip to content

Replace explicit token input with implicit GITHUB_TOKEN [DI-690]#34

Merged
JackPGreen merged 3 commits intohazelcast:masterfrom
JackPGreen:no-pat
Dec 11, 2025
Merged

Replace explicit token input with implicit GITHUB_TOKEN [DI-690]#34
JackPGreen merged 3 commits intohazelcast:masterfrom
JackPGreen:no-pat

Conversation

@JackPGreen
Copy link
Copy Markdown
Contributor

@JackPGreen JackPGreen commented Dec 9, 2025

The action currently requires a token input, which means a typical implementation uses a long-lived PAT:
https://github.com/hazelcast/hz-docs/blob/b01fcb2b18c8cd4eb87dc901ca6972ad9832f1a9/.github/workflows/backport-workflow.yml#L37-L39, and requires pull_request_target execution for that secret to be accessible.

Instead, we should use the default GITHUB_TOKEN to avoid this.

Example execution and resultant PR - note now it's not using devOpsHazelcast's token, PRs will instead by github-actions[bot].

Fixes: DI-690

Post-merge actions:

@JackPGreen JackPGreen self-assigned this Dec 9, 2025
@nishaatr
Copy link
Copy Markdown

would have preferred one PR tbh
little confusing

@JackPGreen
Copy link
Copy Markdown
Contributor Author

would have preferred one PR tbh little confusing

What do you mean?

@JackPGreen
Copy link
Copy Markdown
Contributor Author

would have preferred one PR tbh little confusing

What do you mean?

Now #33 is merged and this branch is updated it should be clearer.

@JackPGreen JackPGreen merged commit bfcc99d into hazelcast:master Dec 11, 2025
3 checks passed
@JackPGreen JackPGreen deleted the no-pat branch December 11, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants