Replace explicit token input with implicit GITHUB_TOKEN [DI-690]#34
Merged
JackPGreen merged 3 commits intohazelcast:masterfrom Dec 11, 2025
Merged
Replace explicit token input with implicit GITHUB_TOKEN [DI-690]#34JackPGreen merged 3 commits intohazelcast:masterfrom
GITHUB_TOKEN [DI-690]#34JackPGreen merged 3 commits intohazelcast:masterfrom
Conversation
|
would have preferred one PR tbh |
Contributor
Author
What do you mean? |
Contributor
Author
Now #33 is merged and this branch is updated it should be clearer. |
nishaatr
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action currently requires a token input, which means a typical implementation uses a long-lived PAT:
https://github.com/hazelcast/hz-docs/blob/b01fcb2b18c8cd4eb87dc901ca6972ad9832f1a9/.github/workflows/backport-workflow.yml#L37-L39, and requires
pull_request_targetexecution for that secret to be accessible.Instead, we should use the default
GITHUB_TOKENto avoid this.Example execution and resultant PR - note now it's not using
devOpsHazelcast's token, PRs will instead bygithub-actions[bot].Fixes: DI-690
Post-merge actions: