Binary instances for NaN and negative zero are broken#46
Closed
Shimuuar wants to merge 1 commit intohaskell:masterfrom
Closed
Binary instances for NaN and negative zero are broken#46Shimuuar wants to merge 1 commit intohaskell:masterfrom
Shimuuar wants to merge 1 commit intohaskell:masterfrom
Conversation
QC doesn't generate such value so they should be listed explicitly
Contributor
|
So if I understand correctly, this PR adds failing tests? |
Contributor
Author
|
Yes. And I think incorrect ones in case of NaNs |
Contributor
|
What exactly is the point of adding failing tests? |
Contributor
Author
|
It's been so long. I don't remember myself. I think it's better to close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roundtripping
(decode . encode)NaN yields -∞ for both Float and Double and roundtripping negative zero gives oridinary zero.This pull request only add tests for transfinite floating point values and does nothing to address issue. It's unclear to me whether it's possible to fix this without breaking encoding format in backward incompatible way.