Open
Conversation
Eric-Wasson
added
enhancement
github-project-automation
bot
moved this to Todo
in 🥂January & February Sprint - Last Milestones for 1.0
Eric-Wasson
moved this from Todo
to Review
in 🥂January & February Sprint - Last Milestones for 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #1251
Only the necessary exception details are already shown (e.g. filename and line number are omitted), but I noticed that the PHP display_errors option is scattered across several files:
Dockerfile: && echo "display_errors = on" >> /usr/local/etc/php/conf.d/custom.ini
ci/server/setup.php:$load = str_replace('ini_set("display_errors", "0");', 'ini_set("display_errors", "1");', $load);
src/inc/startup/include.php:ini_set("display_errors", "0");
src/inc/startup/setup.php:ini_set("display_errors", "0");
src/inc/startup/load.php:ini_set("display_errors", "0");
src/api/v2/index.php:ini_set("display_errors", '1');
Changing the value in only one file may not have the desired effect. So I moved the handling to the ./Dockerfile where it's 1 by default for dev and 0 by default for prod.