Skip to content

Mempool reorg covenants#788

Merged
nodech merged 5 commits intohandshake-org:masterfrom
pinheadmz:mempool-reorg-covenants
Jan 7, 2023
Merged

Mempool reorg covenants#788
nodech merged 5 commits intohandshake-org:masterfrom
pinheadmz:mempool-reorg-covenants

Conversation

@pinheadmz
Copy link
Copy Markdown
Member

Minimal alternative to #773

fixes the bugs without adding additional complexity.

@pinheadmz pinheadmz requested a review from nodech January 5, 2023 18:41
@pinheadmz pinheadmz added this to the hsd 5.0.0 milestone Jan 5, 2023
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 5, 2023

Coverage Status

Coverage: 68.379% (+0.2%) from 68.203% when pulling 0a586d2 on pinheadmz:mempool-reorg-covenants into 309df94 on handshake-org:master.

*/

async _addBlock(block, txs, view) {
if (this.map.size === 0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed? (same as in another PR)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodech nodech added advanced review difficulty - advanced mempool part of the codebase patch Release version labels Jan 6, 2023
@nodech nodech merged commit 6314c1a into handshake-org:master Jan 7, 2023
@nodech nodech mentioned this pull request Jan 17, 2023
@nodech nodech deleted the mempool-reorg-covenants branch January 16, 2024 14:14
nodech added a commit to namebasehq/hsd that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

advanced review difficulty - advanced mempool part of the codebase patch Release version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants