Additional Logging During Tree Sync#668
Merged
nodech merged 1 commit intohandshake-org:masterfrom Dec 9, 2021
Merged
Conversation
Member
|
Closes #660 Thank you for contributing! |
Pull Request Test Coverage Report for Build 1559029358
💛 - Coveralls |
Member
|
@dills122 I want to thank you again for your contribution ;-) However at the same moment you were writing this PR I was about to close this same issue in this PR: #669 If you wanna update your branch with the wording I chose for this log message, I'll merge yours first and then rebase so you get the commit ;-) |
Contributor
Author
|
@pinheadmz No problem! Hoping to get involved more here going forward. Thanks for giving me the commit 😄 |
Contributor
|
Hey, thanks for the contribution ! Can you squash the commits ? That makes master history cleaner w/o redundant commits from the PR. |
1f2916a to
8e2e3b4
Compare
Contributor
|
ACK 8e2e3b4 Show Signaturenodech's public key is on keybase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional logging statement to the beginning of the
syncTreemethod to alert users when the processes kicks off since the process could take a few seconds to complete.